Re: [RFCv8 PATCH net-next 02/55] net: replace general features macroes with global netdev_features variables

在 2022/9/21 20:50, Jakub Kicinski 写道:

On Wed, 21 Sep 2022 18:01:16 +0800 shenjian (K) wrote:

quoted

在 2022/9/21 14:33, shenjian (K) 写道:

quoted

quoted

On Sun, 18 Sep 2022 09:42:43 +0000 Jian Shen wrote:
We shouldn't be changing all these defines here, because that breaks
the build AFAIU.

ok, will keep them until remove the __NETIF_F(name) macro.
  

But I don't see how it break build. Do you mean the definition of

WG_NETDEV_FEATURES in drivers/net/wireguard/device.c ？

Oops, you're right, looks like this patch just adds a warning:

net/core/netdev_features.c:99:13: warning: no previous prototype for function 'netdev_features_init' yi
void __init netdev_features_init(void)

thanks, will fix it.

Build is broken by the next one:

drivers/net/ethernet/microsoft/mana/mana_en.c:2084:2: error: implicit declaration of function 'netdev_hw_features_zero' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
         netdev_hw_features_zero(ndev);
         ^
drivers/net/ethernet/microsoft/mana/mana_en.c:2085:2: error: implicit declaration of function 'netdev_hw_features_set_set' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
         netdev_hw_features_set_set(ndev, NETIF_F_SG_BIT, NETIF_F_IP_CSUM_BIT,
         ^
drivers/net/ethernet/microsoft/mana/mana_en.c:2085:2: note: did you mean 'netdev_hw_features_zero'?
drivers/net/ethernet/microsoft/mana/mana_en.c:2084:2: note: 'netdev_hw_features_zero' declared here
         netdev_hw_features_zero(ndev);
         ^
.

Sorry, I missed include netdev_feature_helpers.h.  I only did compile with allmodconfig on arm64 server, it didn't report build fail.
I should do compile on x86 server too, for mana driver is only supported on X86_64. Thanks!