Re: [PATCH net-next,v2 03/18] selftests/tc-testings: add selftests for cake qdisc

On 2022/9/20 21:52, Toke Høiland-Jørgensen wrote:

Zhengchao Shao [off-list ref] writes:

quoted

Test 1212: Create CAKE with default setting
Test 3281: Create CAKE with bandwidth limit
Test c940: Create CAKE with autorate-ingress flag
Test 2310: Create CAKE with rtt time
Test 2385: Create CAKE with besteffort flag
Test a032: Create CAKE with diffserv8 flag
Test 2349: Create CAKE with diffserv4 flag
Test 8472: Create CAKE with flowblind flag
Test 2341: Create CAKE with dsthost and nat flag
Test 5134: Create CAKE with wash flag
Test 2302: Create CAKE with flowblind and no-split-gso flag
Test 0768: Create CAKE with dual-srchost and ack-filter flag
Test 0238: Create CAKE with dual-dsthost and ack-filter-aggressive flag
Test 6572: Create CAKE with memlimit and ptm flag
Test 2436: Create CAKE with fwmark and atm flag
Test 3984: Create CAKE with overhead and mpu
Test 5421: Create CAKE with conservative and ingress flag
Test 6854: Delete CAKE with conservative and ingress flag
Test 2342: Replace CAKE with mpu
Test 2313: Change CAKE with mpu
Test 4365: Show CAKE class

Signed-off-by: Zhengchao Shao <redacted>

The subject prefix is misspelled for all the test patches (should be
selftests/tc-testing without the last 's').

Also, v2 of the series wasn't properly threaded for some reason, which
makes it harder to apply as a whole.

Other than those nits, for this patch:

Acked-by: Toke Høiland-Jørgensen <redacted>

Hi Toke：
	Thank you for your review. I will send v3.

Zhengchao Shao