Re: [PATCH net-next v14 3/7] net: dsa: Introduce dsa tagger data operation.

On 2022-09-20 12:31, Vladimir Oltean wrote:

On Tue, Sep 20, 2022 at 08:41:30AM +0200, Mattias Forsblad wrote:

quoted

quoted

Can you please also parse the sequence number here, so the
decode_frame2reg() data consumer doesn't have to concern itself with the
dsa_header at all?

The sequence number is in the chip structure which isn't available here.
Should we really access that here in the dsa layer?

I'm talking about this sequence number:

mv88e6xxx_decode_frame2reg_handler:

	/* Decode Frame2Reg DSA portion */
	dsa_header = skb->data - 2;

	seqno = dsa_header[3];

I'm saying, if you get the seqno in net/dsa/tag_dsa.c and pass it as
argument to mv88e6xxx_decode_frame2reg_handler(), then you should no
longer have a reason to look at the dsa_header from drivers/net/dsa/mv88e6xxx/.

Ok, I misunderstood your intent. I'll change. Thanks.

/Mattias