Re: [PATCH net-next v12 5/6] net: dsa: mv88e6xxx: rmon: Use RMU for reading RMON data

On 2022-09-15 22:11, Florian Fainelli wrote:

On 9/15/22 07:36, Mattias Forsblad wrote:

quoted

Use the Remote Management Unit for efficiently accessing
the RMON data.

Signed-off-by: Mattias Forsblad <redacted>

Seems a bit wasteful to add a rmu_reg field for each statistics member when there are only 6 STATS_TYPE_PORT that could be read over RMU.

Maybe what you could do is that the offset in the "reg" member could be split into a lower half that is used to encore the existing offset, and you use the upper half to encode the RMU-offset.

As it's only three port statistics counter, I'll make a switch statement per Andrew suggestion. Thanks.

/Mattias