On 15/09/2022 14:42, Michal Wilczynski wrote:

Currently devlink-rate only have two types of objects: nodes and leafs.
There is a need to extend this interface to account for a third type of
scheduling elements - queues. In our use case customer is sending
different types of traffic on each queue, which requires an ability to
assign rate parameters to individual queues.

Is there a use-case for this queue scheduling in the absence of a netdevice?
If not, then I don't see how this belongs in devlink; the configuration
 should instead be done in two parts: devlink-rate to schedule between
 different netdevices (e.g. VFs) and tc qdiscs (or some other netdev-level
 API) to schedule different queues within each single netdevice.
Please explain why this existing separation does not support your use-case.

Also I would like to see some documentation as part of this patch.  It looks
 like there's no kernel document for devlink-rate unlike most other devlink
 objects; perhaps you could add one?

-ed