Hi Jiri,

Agree with you, we will work on aligning to the GNSS subsystem if that would be
possible in our implementation according to Johan suggestion.

We will also make sure to make our code less "interesting", when comes to constructs.

Thanks a lot!

BR,
M^2

-----Original Message-----
From: Jiri Slaby <jirislaby@kernel.org> 
Sent: Friday, September 2, 2022 12:47 PM
To: Johan Hovold <johan@kernel.org>; Jakub Kicinski <kuba@kernel.org>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Michalik, Michal <redacted>; netdev@vger.kernel.org; richardcochran@gmail.com; G, GurucharanX <redacted>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS

On 02. 09. 22, 9:42, Jiri Slaby wrote:

quoted

On 01. 09. 22, 8:44, Johan Hovold wrote:

quoted

Looks like this was merged in 5.18 with 43113ff73453 ("ice: add TTY for
GNSS module for E810T device") without any input from people familiar
with tty either.

FWIW doesn't it crash in ice_gnss_tty_write() on parallel tty opens due to:
          tty->driver_data = NULL;
in ice_gnss_tty_open()?

Oh, the driver checks for tty->driver_data in every operation (gee). So 
at least that crash is mitigated. The userspace will "only" receive 
EFAULT from time to time.

quoted

There are many "interesting" constructs in the driver...

The checks belong among this "interesting" constructs too.

quoted

thanks,-- 

js
suse labs