Re: [PATCH net-next v4 6/7] dt-bindings: net: pse-dt: add bindings for generic PSE controller
flat view
From: Krzysztof Kozlowski <hidden>
Date: 2022-08-30 17:44:53
Also in:
linux-devicetree, linux-doc, lkml
On 28/08/2022 09:30, Oleksij Rempel wrote:
quoted hunk ↗ jump to hunk
Add binding for generic Ethernet PSE controller. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- changes v4: - rename to PSE regulator - drop currently unused properties - use own compatible for PoDL PSE changes v2: - rename compatible to more generic "ieee802.3-pse" - add class and type properties for PoDL and PoE variants - add pairs property --- .../bindings/net/pse-pd/pse-regulator.yaml | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/pse-pd/pse-regulator.yamldiff --git a/Documentation/devicetree/bindings/net/pse-pd/pse-regulator.yaml b/Documentation/devicetree/bindings/net/pse-pd/pse-regulator.yaml new file mode 100644 index 0000000000000..1a906d2135a7a --- /dev/null +++ b/Documentation/devicetree/bindings/net/pse-pd/pse-regulator.yaml@@ -0,0 +1,40 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/pse-pd/pse-regulator.yaml#
The convention is filename based on compatible, so "podl-pse-regulator.yaml"
quoted hunk ↗ jump to hunk
+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Regulator based Power Sourcing Equipment + +maintainers: + - Oleksij Rempel <o.rempel@pengutronix.de> + +description: Regulator based PSE controller. The device must be referenced by + the PHY node to control power injection to the Ethernet cable. + +properties: + compatible: + description: Regulator based PoDL PSE controller for a single twisted-pair + link.
Why description of compatible? Description of hardware goes to top-level description.
quoted hunk ↗ jump to hunk
+ const: podl-pse-regulator + + '#pse-cells': + const: 0 + + pse-supply: + description: Power supply for the PSE controller + +additionalProperties: false + +required: + - compatible + - '#pse-cells' + - pse-supply + +examples: + - | + pse_t1l2: ethernet-pse-1 {
Node name: ethernet-pse (unless -1 stands for something generic?) Also, no need for label. Best regards, Krzysztof