Re: [PATCH -next] net: sched: sch_skbprio: add support for qlen statistics of each priority in sch_skbprio
From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-08-27 02:46:25
Also in:
lkml
On Thu, 25 Aug 2022 18:27:45 +0800 Zhengchao Shao wrote:
quoted hunk ↗ jump to hunk
diff --git a/net/sched/sch_skbprio.c b/net/sched/sch_skbprio.c index 7a5e4c454715..fe2bb7bf9d2a 100644 --- a/net/sched/sch_skbprio.c +++ b/net/sched/sch_skbprio.c@@ -83,6 +83,7 @@ static int skbprio_enqueue(struct sk_buff *skb, struct Qdisc *sch, __skb_queue_tail(qdisc, skb);
The skb queue called "qdisc" here (confusingly) already maintains a length (also called qlen). Can we just access that variable instead of maintaining the same value manually?
qdisc_qstats_backlog_inc(sch, skb); q->qstats[prio].backlog += qdisc_pkt_len(skb); + q->qstats[prio].qlen++;