Re: [PATCH V4 2/3] arm64: dts: imx8ulp: Add the fec support
From: Shawn Guo <shawnguo@kernel.org>
Date: 2022-08-17 09:48:15
Also in:
linux-arm-kernel, linux-devicetree, lkml
On Wed, Jul 27, 2022 at 12:38:52AM +1000, wei.fang@nxp.com wrote:
quoted hunk ↗ jump to hunk
From: Wei Fang <wei.fang@nxp.com> Add the fec support on i.MX8ULP platforms. Signed-off-by: Wei Fang <wei.fang@nxp.com> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de> --- V2 change: Remove the external clocks which is related to specific board. V3 change: No change. V4 Change: Add Reviewed-by tag. --- arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi index 60c1b018bf03..3e8a1e4f0fc2 100644 --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi@@ -16,6 +16,7 @@ / { #size-cells = <2>; aliases { + ethernet0 = &fec; gpio0 = &gpiod; gpio1 = &gpioe; gpio2 = &gpiof;@@ -365,6 +366,16 @@ usdhc2: mmc@298f0000 { bus-width = <4>; status = "disabled"; }; + + fec: ethernet@29950000 { + compatible = "fsl,imx8ulp-fec", "fsl,imx6ul-fec", "fsl,imx6q-fec";
Since imx8ulp-fec is compatible with imx6ul-fec, what's the point of having imx6q-fec in there? It can be dropped, I guess? Shawn
+ reg = <0x29950000 0x10000>;
+ interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "int0";
+ fsl,num-tx-queues = <1>;
+ fsl,num-rx-queues = <1>;
+ status = "disabled";
+ };
};
gpioe: gpio@2d000080 {
--
2.25.1