Re: [RFC PATCH v3 7/9] virtio/vsock: check SO_RCVLOWAT before wake up reader
From: Stefano Garzarella <sgarzare@redhat.com>
Date: 2022-08-08 10:58:58
Also in:
kvm, linux-hyperv, lkml, virtualization
On Wed, Aug 03, 2022 at 02:03:58PM +0000, Arseniy Krasnov wrote:
This adds extra condition to wake up data reader: do it only when number of readable bytes >= SO_RCVLOWAT. Otherwise, there is no sense to kick user,because it will wait until SO_RCVLOWAT bytes will be dequeued.
Maybe we can mention that these are done in vsock_data_ready(). Anyway, the patch LGTM: Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
quoted hunk ↗ jump to hunk
Signed-off-by: Arseniy Krasnov <redacted> --- net/vmw_vsock/virtio_transport_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c index 8f6356ebcdd1..35863132f4f1 100644 --- a/net/vmw_vsock/virtio_transport_common.c +++ b/net/vmw_vsock/virtio_transport_common.c@@ -1081,7 +1081,7 @@ virtio_transport_recv_connected(struct sock *sk,switch (le16_to_cpu(pkt->hdr.op)) { case VIRTIO_VSOCK_OP_RW: virtio_transport_recv_enqueue(vsk, pkt); - sk->sk_data_ready(sk); + vsock_data_ready(sk); return err; case VIRTIO_VSOCK_OP_CREDIT_REQUEST: virtio_transport_send_credit_update(vsk); -- 2.25.1