Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi

Andy Shevchenko · 2022-08-05T19:58:06+0200

On Fri, Aug 5, 2022 at 7:44 PM Colin Foster wrote: > > As I'm going through Andy's suggestions, I came across a couple more > include changes / misses: > > On Tue, Aug 02, 2022 at 10:47:28PM -0700, Colin Foster wrote: ... > > +int ocelot_chip_reset(struct device *dev) > > #include Nope, struct device; ... > > +static int ocelot_spi_initialize(struct device *dev) > > #include Ditto. -- With Best Regards, Andy Shevchenko

[PATCH v15 mfd 0/9] add support for VSC7512 control over SPI · Colin Foster <colin.foster@in-advantage.com> · 2022-08-03
[PATCH v15 mfd 1/9] mfd: ocelot: add helper to get regmap from a resource · Colin Foster <colin.foster@in-advantage.com> · 2022-08-03
Re: [PATCH v15 mfd 1/9] mfd: ocelot: add helper to get regmap from a resource · Andy Shevchenko <hidden> · 2022-08-03
[PATCH v15 mfd 2/9] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration · Colin Foster <colin.foster@in-advantage.com> · 2022-08-03
Re: [PATCH v15 mfd 2/9] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration · Andy Shevchenko <hidden> · 2022-08-03
[PATCH v15 mfd 3/9] pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module · Colin Foster <colin.foster@in-advantage.com> · 2022-08-03
Re: [PATCH v15 mfd 3/9] pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module · Andy Shevchenko <hidden> · 2022-08-03
[PATCH v15 mfd 4/9] pinctrl: ocelot: add ability to be used in a non-mmio configuration · Colin Foster <colin.foster@in-advantage.com> · 2022-08-03
Re: [PATCH v15 mfd 4/9] pinctrl: ocelot: add ability to be used in a non-mmio configuration · Andy Shevchenko <hidden> · 2022-08-03
[PATCH v15 mfd 5/9] pinctrl: microchip-sgpio: allow sgpio driver to be used as a module · Colin Foster <colin.foster@in-advantage.com> · 2022-08-03
Re: [PATCH v15 mfd 5/9] pinctrl: microchip-sgpio: allow sgpio driver to be used as a module · Andy Shevchenko <hidden> · 2022-08-03
[PATCH v15 mfd 7/9] resource: add define macro for register address resources · Colin Foster <colin.foster@in-advantage.com> · 2022-08-03
Re: [PATCH v15 mfd 7/9] resource: add define macro for register address resources · Andy Shevchenko <hidden> · 2022-08-03
[PATCH v15 mfd 6/9] pinctrl: microchip-sgpio: add ability to be used in a non-mmio configuration · Colin Foster <colin.foster@in-advantage.com> · 2022-08-03
Re: [PATCH v15 mfd 6/9] pinctrl: microchip-sgpio: add ability to be used in a non-mmio configuration · Andy Shevchenko <hidden> · 2022-08-03
[PATCH v15 mfd 8/9] dt-bindings: mfd: ocelot: add bindings for VSC7512 · Colin Foster <colin.foster@in-advantage.com> · 2022-08-03
[PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi · Colin Foster <colin.foster@in-advantage.com> · 2022-08-03
Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi · Andy Shevchenko <hidden> · 2022-08-03
Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi · Colin Foster <colin.foster@in-advantage.com> · 2022-08-03
Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi · Andy Shevchenko <hidden> · 2022-08-03
Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi · Colin Foster <colin.foster@in-advantage.com> · 2022-08-03
Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi · Colin Foster <colin.foster@in-advantage.com> · 2022-08-05
Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi · Andy Shevchenko <hidden> · 2022-08-05
Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi · Colin Foster <colin.foster@in-advantage.com> · 2022-08-05
Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi · Andy Shevchenko <hidden> · 2022-08-05

From: Andy Shevchenko <hidden>
Date: 2022-08-05 17:58:54
Also in: linux-arm-kernel, linux-devicetree, linux-gpio, lkml

On Fri, Aug 5, 2022 at 7:44 PM Colin Foster
[off-list ref] wrote:

As I'm going through Andy's suggestions, I came across a couple more
include changes / misses:

On Tue, Aug 02, 2022 at 10:47:28PM -0700, Colin Foster wrote:

...

quoted

+int ocelot_chip_reset(struct device *dev)

#include <linux/device.h>

Nope,

struct device;

...

quoted

+static int ocelot_spi_initialize(struct device *dev)

#include <linux/device.h>

Ditto.

-- 
With Best Regards,
Andy Shevchenko

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help