RE: [Intel-wired-lan] [PATCH] ixgbe: Use kmap_local_page in ixgbe_check_lbtest_frame()
From: G, GurucharanX <hidden>
Date: 2022-08-04 12:54:21
Also in:
bpf, intel-wired-lan, lkml
From: G, GurucharanX <hidden>
Date: 2022-08-04 12:54:21
Also in:
bpf, intel-wired-lan, lkml
-----Original Message----- From: Intel-wired-lan <redacted> On Behalf Of Fabio M. De Francesco Sent: Wednesday, June 29, 2022 2:29 PM To: Brandeburg, Jesse <redacted>; Nguyen, Anthony L [off-list ref]; David S. Miller [off-list ref]; Eric Dumazet [off-list ref]; Jakub Kicinski [off-list ref]; Paolo Abeni [off-list ref]; Alexei Starovoitov [off-list ref]; Daniel Borkmann [off-list ref]; Jesper Dangaard Brouer [off-list ref]; John Fastabend [off-list ref]; intel- wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux- kernel@vger.kernel.org; bpf@vger.kernel.org Cc: Weiny, Ira <ira.weiny@intel.com>; Fabio M. De Francesco [off-list ref] Subject: [Intel-wired-lan] [PATCH] ixgbe: Use kmap_local_page in ixgbe_check_lbtest_frame() The use of kmap() is being deprecated in favor of kmap_local_page(). With kmap_local_page(), the mapping is per thread, CPU local and not globally visible. Furthermore, the mapping can be acquired from any context (including interrupts). Therefore, use kmap_local_page() in ixgbe_check_lbtest_frame() because this mapping is per thread, CPU local, and not globally visible. Suggested-by: Ira Weiny <ira.weiny@intel.com> Signed-off-by: Fabio M. De Francesco <redacted> --- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Tested-by: Gurucharan <redacted> (A Contingent worker at Intel)