On 8/18/2022 4:21 PM, Ilpo Järvinen wrote:

On Wed, 17 Aug 2022, Kumar, M Chetan wrote:

quoted

On 8/17/2022 5:40 PM, Ilpo Järvinen wrote:

quoted

On Tue, 16 Aug 2022, m.chetan.kumar@intel.com wrote:

quoted

From: Haijun Liu <haijun.liu@mediatek.com>

<skip>

quoted

quoted

@@ -372,7 +435,8 @@ static int t7xx_port_proxy_recv_skb(struct cldma_queue

*queue, struct sk_buff *s
     	seq_num = t7xx_port_next_rx_seq_num(port, ccci_h);
   	port_conf = port->port_conf;
-	skb_pull(skb, sizeof(*ccci_h));
+	if (!port->port_conf->is_early_port)
+		skb_pull(skb, sizeof(*ccci_h));

This seems to be the only user for is_early_port, wouldn't be more obvious
to store the header size instead?

Early port doesn't carry header.
If we change it to header size, skb_pull() operators on zero length.

Is that a problem?

Looking into the implementation details, feels like it should be OK.
But knowingly the len is zero thought to avoid.

quoted

OR may need another such flag to bypass it.

You could use if (header_size) if you don't want to skb_pull with zero len
so I don't know why another flag would be needed?

Ok. I will replace is_early_port with header_size & use it as check for 
skb_pull().

-- 
Chetan