Thread (8 messages) flat view 8 messages, 3 authors, 2022-08-12

Re: [PATCH vhost 0/2] virtio_net: fix for stuck when change ring size with dev down

From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Date: 2022-08-11 08:13:24
Also in: virtualization

On Thu, 11 Aug 2022 04:11:22 -0400, "Michael S. Tsirkin" [off-list ref] wrote:
On Thu, Aug 11, 2022 at 04:02:56PM +0800, Xuan Zhuo wrote:
quoted
When dev is set to DOWN state, napi has been disabled, if we modify the
ring size at this time, we should not call napi_disable() again, which
will cause stuck.

And all operations are under the protection of rtnl_lock, so there is no
need to consider concurrency issues.

PS.
Hi Michael, I don't know which way is more convenient for you, so I split the
commit into two commits, so you can fixup to my previous commit:

    virtio_net: support tx queue resize
	virtio_net: support rx queue resize

Xuan Zhuo (2):
  virtio_net: fix for stuck when change rx ring size with dev down
  virtio_net: fix for stuck when change tx ring size with dev down

 drivers/net/virtio_net.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

Which patches does this fix?
Maybe I should squash.
These two:
     virtio_net: support tx queue resize
     virtio_net: support rx queue resize

Thanks.

quoted
--
2.31.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help