Re: [PATCH for-rc] RDMA/cxgb4: fix accept failure due to increased cpl_t5_pass_accept_rpl size
From: Kees Cook <hidden>
Date: 2022-08-09 22:59:26
Also in:
linux-rdma
On Wed, Aug 10, 2022 at 12:11:18AM +0530, Rahul Lakkireddy wrote:
From: Potnuri Bharat Teja <bharat@chelsio.com>
Commit 'c2ed5611afd7' has increased the cpl_t5_pass_accept_rpl{} structure
size by 8B to avoid roundup. cpl_t5_pass_accept_rpl{} is a HW specific
structure and increasing its size will lead to unwanted adapter errors.
Current commit reverts the cpl_t5_pass_accept_rpl{} back to its original
and allocates zeroed skb buffer there by avoiding the memset for iss field.
Reorder code to minimize chip type checks.
Fixes: c2ed5611afd7 ("iw_cxgb4: Use memset_startat() for cpl_t5_pass_accept_rpl")
Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
Signed-off-by: Rahul Lakkireddy <redacted>Thanks for the better solution! Reviewed-by: Kees Cook <redacted> -- Kees Cook