Thread (2 messages) read the whole thread 2 messages, 2 authors, 2022-08-08

cmd_sb_occ_show doesn't call dl_put_opts

From: Jacob Keller <jacob.e.keller@intel.com>
Date: 2022-08-05 20:18:37

Hey Jiri,

I noticed while looking at implementing policy checking support in
devlink that the cmd_sb_occ_show calls dl_argv_parse but then doesn't
call dl_put_opts, so it doesn't seem to be sending any of the attributes
down to the kernel.

I am guessing this is not done on purpose, and is just an oversight,
caused by needing to send two different netlink messages.

It looks like the code could use a dl_argc check to determine whether to
use NLM_F_DUMP and call dl_put_opts to ensure the netlink attributes get
added..?

Thanks,
Jake
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help