On Mon, Aug 1, 2022 at 6:57 AM Cezar Bulinaru [off-list ref] wrote:

Few test cases related to the fix for 924a9bc362a5:
"net: check if protocol extracted by virtio_net_hdr_set_proto is correct"

Need test for the case when a non-standard packet (GSO without NEEDS_CSUM)
sent to the tap device causes a BUG check in the tap driver.

Signed-off-by: Cezar Bulinaru <redacted>

Thanks a lot for adding initial tap tests.

It is still missing .gitignore.

+FIXTURE_TEARDOWN(tap)
+{
+       int ret;
+
+       if (self->fd != -1)
+               close(self->fd);
+
+       ret = dev_delete(param_dev_dummy_name);
+       EXPECT_EQ(ret, 0);
+
+       ret = dev_delete(param_dev_tap_name);
+       EXPECT_EQ(ret, 0);

Should this remove the tap device before removing the dummy device?