On Fri, Jul 1, 2022 at 3:04 PM Srivats P [off-list ref] wrote:

quoted

I can push xsk_fwd to BPF-examples. Though I do think that xdpsock has
become way too big to serve as a sample. It slowly turned into a catch
all demonstrating every single feature of AF_XDP. We need a minimal
example and then likely other samples for other features that should
be demoed. So I suggest that xdpsock dies here and we start over with
something minimal and use xsk_fwd for the forwarding and mempool
example.

As an AF_XDP user, I want to say that I often refer to xdpsock to
understand how to use a feature - it is very useful especially when
there's a lack of good AF_XDP documentation.

Fully agree with you that we need a sample, but a better location for
it is in libxdp as xdpsock demonstrates how to use libxdp interfaces.
We cannot require that people install libxdp just to be able to
compile samples/bpf/. And the sample should be simpler IMO. So let us
use this as an opportunity to improve things.

Srivats