Re: [PATCH v11 24/40] virtio_pci: struct virtio_pci_common_cfg add queue_notify_data
From: Jason Wang <jasowang@redhat.com>
Date: 2022-07-01 09:34:32
Also in:
bpf, kvm, linux-remoteproc, linux-s390, linux-um, platform-driver-x86, virtualization
在 2022/6/29 14:56, Xuan Zhuo 写道:
quoted hunk ↗ jump to hunk
Add queue_notify_data in struct virtio_pci_common_cfg, which comes from here https://github.com/oasis-tcs/virtio-spec/issues/89 Since I want to add queue_reset after queue_notify_data, I submitted this patch first. Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com> Acked-by: Jason Wang <jasowang@redhat.com> --- include/linux/virtio_pci_modern.h | 2 ++ include/uapi/linux/virtio_pci.h | 1 + 2 files changed, 3 insertions(+)diff --git a/include/linux/virtio_pci_modern.h b/include/linux/virtio_pci_modern.h index c4f7ffbacb4e..9f31dde46f57 100644 --- a/include/linux/virtio_pci_modern.h +++ b/include/linux/virtio_pci_modern.h@@ -29,6 +29,8 @@ struct virtio_pci_common_cfg { __le32 queue_avail_hi; /* read-write */ __le32 queue_used_lo; /* read-write */ __le32 queue_used_hi; /* read-write */ + __le16 queue_notify_data; /* read-write */ + __le16 padding; };
As previous patch, I think it's better to simple embed the uAPI structure here. Thanks
quoted hunk ↗ jump to hunk
struct virtio_pci_modern_device {diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h index 247ec42af2c8..748b3eb62d2f 100644 --- a/include/uapi/linux/virtio_pci.h +++ b/include/uapi/linux/virtio_pci.h@@ -176,6 +176,7 @@ struct virtio_pci_cfg_cap { #define VIRTIO_PCI_COMMON_Q_AVAILHI 44 #define VIRTIO_PCI_COMMON_Q_USEDLO 48 #define VIRTIO_PCI_COMMON_Q_USEDHI 52 +#define VIRTIO_PCI_COMMON_Q_NDATA 56 #endif /* VIRTIO_PCI_NO_MODERN */