Re: [PATCH V6] virtio-net: fix the race between refill work and close
From: patchwork-bot+netdevbpf@kernel.org
Date: 2022-07-27 12:31:05
Also in:
lkml
From: patchwork-bot+netdevbpf@kernel.org
Date: 2022-07-27 12:31:05
Also in:
lkml
Hello: This patch was applied to netdev/net.git (master) by David S. Miller [off-list ref]: On Mon, 25 Jul 2022 15:21:59 +0800 you wrote:
We try using cancel_delayed_work_sync() to prevent the work from enabling NAPI. This is insufficient since we don't disable the source of the refill work scheduling. This means an NAPI poll callback after cancel_delayed_work_sync() can schedule the refill work then can re-enable the NAPI that leads to use-after-free [1]. Since the work can enable NAPI, we can't simply disable NAPI before calling cancel_delayed_work_sync(). So fix this by introducing a dedicated boolean to control whether or not the work could be scheduled from NAPI. [...]
Here is the summary with links:
- [V6] virtio-net: fix the race between refill work and close
https://git.kernel.org/netdev/net/c/5a159128faff
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html