Re: [for-next][PATCH 17/23] batman-adv: tracing: Use the new __vstring() helper
flat view
From: Sven Eckelmann <sven@narfation.org>
Date: 2022-07-24 21:40:49
Also in:
batman, lkml
On Thursday, 14 July 2022 18:43:13 CEST Steven Rostedt wrote:
From: "Steven Rostedt (Google)" <rostedt@goodmis.org> Instead of open coding a __dynamic_array() with a fixed length (which defeats the purpose of the dynamic array in the first place).
Please also make sure to remove the define of BATADV_MAX_MSG_LEN Kind regards, Sven [...]
quoted hunk ↗ jump to hunk
--- a/net/batman-adv/trace.h +++ b/net/batman-adv/trace.h@@ -40,16 +40,13 @@ TRACE_EVENT(batadv_dbg, TP_STRUCT__entry( __string(device, bat_priv->soft_iface->name) __string(driver, KBUILD_MODNAME) - __dynamic_array(char, msg, BATADV_MAX_MSG_LEN) + __vstring(msg, vaf->fmt, vaf->va) ), TP_fast_assign( __assign_str(device, bat_priv->soft_iface->name); __assign_str(driver, KBUILD_MODNAME); - WARN_ON_ONCE(vsnprintf(__get_dynamic_array(msg), - BATADV_MAX_MSG_LEN, - vaf->fmt, - *vaf->va) >= BATADV_MAX_MSG_LEN); + __assign_vstr(msg, vaf->fmt, vaf->va); ), TP_printk(
Attachments
- signature.asc [application/pgp-signature] 833 bytes