On Wed, Mar 02, 2022 at 10:32:48PM -0800, Jakub Kicinski wrote:

On Mon, 28 Feb 2022 19:15:58 +0800 Wong Vee Khee wrote:

quoted

From: Ling Pei Lee <redacted>

Sequential execution of these steps:
i) TSO ON – iperf3 execution,
ii) TSO OFF – iperf3 execution,
iii) TSO ON – iperf3 execution, it leads to iperf3 0 bytes transfer.

IMHO the iperf output can be dropped from the commit message, 
it doesn't add much beyond this description.

Noted. Will drop those on next revision of pull request.
 

quoted

Clear mss in TDES and call stmmac_enable_tso() to indicate
a new TSO transmission when it is enabled from TSO off using
ethtool command

How does the TSO get disabled I don't see any ...enable_tso(, 0, )
calls in the driver? And why call enable in fix_features rather 
than set_features?

It is disable when 'priv->tso = 0' in this same function.
The reason I put this in fix_features rather than set_features is
because the commit f748be531d70("stmmac: support new GMAC4") has
already introduced the following codes in fix_features:-

+	/* Disable tso if asked by ethtool */
+	if ((priv->plat->tso_en) && (priv->dma_cap.tsoen)) {
+		if (features & NETIF_F_TSO)
+			priv->tso = true;
+		else
+			priv->tso = false;
+	}

BR,
 Vee Khee