Re: [PATCH bpf-next v6 21/23] samples/bpf: add new hid_mouse example
From: Dominique Martinet <asmadeus@codewreck.org>
Date: 2022-07-13 12:07:27
Also in:
bpf, linux-doc, linux-input, linux-kselftest, lkml
Benjamin Tissoires wrote on Tue, Jul 12, 2022 at 04:58:48PM +0200:
quoted hunk ↗ jump to hunk
diff --git a/samples/bpf/hid_mouse.c b/samples/bpf/hid_mouse.c new file mode 100644 index 000000000000..f6e5f09026eb --- /dev/null +++ b/samples/bpf/hid_mouse.c@@ -0,0 +1,150 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* Copyright (c) 2022 Benjamin Tissoires + */ + +/* not sure why but this doesn't get preoperly imported */
typo: properly
+#define __must_check
But more usefully, I don't think it should be needed -- we don't use __must_check at all in uapi includes; if this is needed that means some of the include here uses the kernel internal includes and that shouldn't be needed as they're not normally installed. Didn't actually try to see but taking the compilation line that fails and running it with -E will probably show where that must_check comes from -- Dominique Martinet | Asmadeus, just passing by