Re: [PATCH v5 11/11] net/9p: allocate appropriate reduced message buffers
From: Dominique Martinet <asmadeus@codewreck.org>
Date: 2022-07-12 19:45:49
Also in:
lkml
From: Dominique Martinet <asmadeus@codewreck.org>
Date: 2022-07-12 19:45:49
Also in:
lkml
Christian Schoenebeck wrote on Tue, Jul 12, 2022 at 04:31:36PM +0200:
So far 'msize' was simply used for all 9p message types, which is far too much and slowed down performance tremendously with large values for user configurable 'msize' option. Let's stop this waste by using the new p9_msg_buf_size() function for allocating more appropriate, smaller buffers according to what is actually sent over the wire. Only exception: RDMA transport is currently excluded from this, as it would not cope with it. [1] Link: https://lore.kernel.org/all/YkmVI6pqTuMD8dVi@codewreck.org/ (local) [1] Signed-off-by: Christian Schoenebeck <linux_oss@crudebyte.com> --- Is the !strcmp(c->trans_mod->name, "rdma") check in this patch maybe a bit too hack-ish? Should there rather be transport API extension instead?
hmm yeah that doesn't feel great, let's add a flag to struct p9_trans_module -- Dominique