Thread (69 messages) 69 messages, 11 authors, 2022-08-15

Re: [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state()

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2022-07-01 07:30:49
Also in: linux-gpio, linux-iommu, linux-pm, lkml

Hi Saravana,

On Fri, Jul 1, 2022 at 2:37 AM Saravana Kannan [off-list ref] wrote:
On Thu, Jun 23, 2022 at 5:08 AM Alexander Stein
[off-list ref] wrote:
quoted
Am Dienstag, 21. Juni 2022, 09:28:43 CEST schrieb Tony Lindgren:
quoted
quoted
* Saravana Kannan [off-list ref] [700101 02:00]:
quoted
Now that fw_devlink=on by default and fw_devlink supports
"power-domains" property, the execution will never get to the point
where driver_deferred_probe_check_state() is called before the supplier
has probed successfully or before deferred probe timeout has expired.

So, delete the call and replace it with -ENODEV.
Looks like this causes omaps to not boot in Linux next. With this
simple-pm-bus fails to probe initially as the power-domain is not
yet available. On platform_probe() genpd_get_from_provider() returns
-ENOENT.

Seems like other stuff is potentially broken too, any ideas on
how to fix this?
I think I'm hit by this as well, although I do not get a lockup.
In my case I'm using arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dts
and probing of 38320000.blk-ctrl fails as the power-domain is not (yet)
registed.
Ok, took a look.

The problem is that there are two drivers for the same device and they
both initialize this device.

    gpc: gpc@303a0000 {
        compatible = "fsl,imx8mq-gpc";
    }

$ git grep -l "fsl,imx7d-gpc" -- drivers/
drivers/irqchip/irq-imx-gpcv2.c
drivers/soc/imx/gpcv2.c
You missed the "driver" in arch/arm/mach-imx/src.c ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help