RE: [PATCH iproute-next v3 3/3] f_flower: Introduce PPPoE support
From: Drewek, Wojciech <hidden>
Date: 2022-07-28 11:25:00
From: Drewek, Wojciech <hidden>
Date: 2022-07-28 11:25:00
-----Original Message----- From: Guillaume Nault <redacted> Sent: czwartek, 28 lipca 2022 13:18 To: Drewek, Wojciech <redacted> Cc: netdev@vger.kernel.org; dsahern@gmail.com; stephen@networkplumber.org Subject: Re: [PATCH iproute-next v3 3/3] f_flower: Introduce PPPoE support On Thu, Jul 28, 2022 at 01:01:17PM +0200, Wojciech Drewek wrote:quoted
Introduce PPPoE specific fields in tc-flower: - session id (16 bits) - ppp protocol (16 bits) Those fields can be provided only when protocol was set to ETH_P_PPP_SES. ppp_proto works similar to vlan_ethtype, i.e. ppp_proto overwrites eth_type. Thanks to that, fields from encapsulated protocols (such as src_ip) can be specified.Acked-by: Guillaume Nault <redacted> Thanks for working on PPP/PPPoE!
It's our pleasure. Thanks for your involvement in the review!