On Mon, Jul 04, 2022 at 07:50:11PM -0700, Jakub Kicinski wrote:

On Mon,  4 Jul 2022 12:52:23 +0200 David Lamparter wrote:

quoted

+const struct nla_policy rtm_ipv6_mr_policy[RTA_MAX + 1] = {
+	[RTA_SRC]		= NLA_POLICY_EXACT_LEN(sizeof(struct in6_addr)),
+	[RTA_DST]		= NLA_POLICY_EXACT_LEN(sizeof(struct in6_addr)),
+	[RTA_TABLE]		= { .type = NLA_U32 },
+};

net/ipv6/ip6mr.c:2515:25: warning: symbol 'rtm_ipv6_mr_policy' was not declared. Should it be static?

As the great poet of our time, Homer Simpson, would say:  "d'oh"

After thinking about it for a bit more, I agree with Nikolay that the
policy shouldn't be reused, so apart from adding the "static" here I'll
also rename it to clarify it's the RTM_GETROUTE policy.


-equi/David