RE: [PATCH V3 6/6] vDPA: fix 'cast to restricted le16' warnings in vdpa.c
From: Parav Pandit <hidden>
Date: 2022-07-01 22:18:28
Also in:
virtualization
From: Zhu Lingshan <redacted> Sent: Friday, July 1, 2022 9:28 AM This commit fixes spars warnings: cast to restricted __le16 in function vdpa_dev_net_config_fill() and vdpa_fill_stats_rec()
Missing fixes tag. But I fail to understand the warning. config.status is le16, and API used is to convert le16 to cpu. What is the warning about, can you please explain?
quoted hunk ↗ jump to hunk
Signed-off-by: Zhu Lingshan <redacted> --- drivers/vdpa/vdpa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c index846dd37f3549..ed49fe46a79e 100644--- a/drivers/vdpa/vdpa.c +++ b/drivers/vdpa/vdpa.c@@ -825,11 +825,11 @@ static int vdpa_dev_net_config_fill(structvdpa_device *vdev, struct sk_buff *ms config.mac)) return -EMSGSIZE; - val_u16 = le16_to_cpu(config.status); + val_u16 = __virtio16_to_cpu(true, config.status); if (nla_put_u16(msg, VDPA_ATTR_DEV_NET_STATUS, val_u16)) return -EMSGSIZE; - val_u16 = le16_to_cpu(config.mtu); + val_u16 = __virtio16_to_cpu(true, config.mtu); if (nla_put_u16(msg, VDPA_ATTR_DEV_NET_CFG_MTU, val_u16)) return -EMSGSIZE;@@ -911,7 +911,7 @@ static int vdpa_fill_stats_rec(struct vdpa_device*vdev, struct sk_buff *msg, } vdpa_get_config_unlocked(vdev, 0, &config, sizeof(config)); - max_vqp = le16_to_cpu(config.max_virtqueue_pairs); + max_vqp = __virtio16_to_cpu(true, config.max_virtqueue_pairs); if (nla_put_u16(msg, VDPA_ATTR_DEV_NET_CFG_MAX_VQP, max_vqp)) return -EMSGSIZE; -- 2.31.1