Thread (22 messages) 22 messages, 5 authors, 2022-06-30

Re: [RFC PATCH v1 3/3] ptp_ocp: implement DPLL ops

From: Vadim Fedorenko <hidden>
Date: 2022-06-27 22:06:06
Also in: linux-arm-kernel

On 27.06.2022 20:23, Jonathan Lemon wrote:
On Sun, Jun 26, 2022 at 08:27:17PM +0100, Vadim Fedorenko wrote:
quoted
On 23.06.2022 19:28, Jonathan Lemon wrote:
quoted
On Thu, Jun 23, 2022 at 03:57:17AM +0300, Vadim Fedorenko wrote:
quoted
From: Vadim Fedorenko <redacted>

+static int ptp_ocp_dpll_get_status(struct dpll_device *dpll)
+{
+	struct ptp_ocp *bp = (struct ptp_ocp *)dpll_priv(dpll);
+	int sync;
+
+	sync = ioread32(&bp->reg->status) & OCP_STATUS_IN_SYNC;
+	return sync;
+}
Please match existing code style.
Didn't get this point. The same code is used through out the driver.
Could you please explain?
Match existing function definition style.
Got it. Will address in the next version, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help