Thread (1 message) 1 message, 1 author, 2022-06-29

Re: [PATCH 6/6] i2c: Make remove callback return void

From: Uwe Kleine-König <hidden>
Date: 2022-06-29 13:35:51
Also in: chrome-platform, dri-devel, linux-arm-kernel, linux-clk, linux-crypto, linux-devicetree, linux-fbdev, linux-gpio, linux-hwmon, linux-i2c, linux-iio, linux-input, linux-integrity, linux-leds, linux-mediatek, linux-omap, linux-pm, linux-pwm, linux-rtc, linux-serial, linux-staging, linux-usb, linux-watchdog, linuxppc-dev, platform-driver-x86

Possibly related (same subject, not in this thread)

[Dropped most people from Cc, keeping only lists]

On Wed, Jun 29, 2022 at 04:11:26PM +0300, Andrey Ryabinin wrote:
On 6/28/22 17:03, Uwe Kleine-König wrote:
quoted
From: Uwe Kleine-König <redacted>

The value returned by an i2c driver's remove function is mostly ignored.
(Only an error message is printed if the value is non-zero that the
error is ignored.)

So change the prototype of the remove function to return no value. This
way driver authors are not tempted to assume that passing an error to
the upper layer is a good idea. All drivers are adapted accordingly.
There is no intended change of behaviour, all callbacks were prepared to
return 0 before.

Signed-off-by: Uwe Kleine-König <redacted>
---
                                    | 2 +-
quoted
 lib/Kconfig.kasan                                         | 1 +
quoted
diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan
index f0973da583e0..366e61639cb2 100644
--- a/lib/Kconfig.kasan
+++ b/lib/Kconfig.kasan
@@ -149,6 +149,7 @@ config KASAN_STACK
      depends on KASAN_GENERIC || KASAN_SW_TAGS
      depends on !ARCH_DISABLE_KASAN_INLINE
      default y if CC_IS_GCC
+     depends on !ARM
      help
        Disables stack instrumentation and thus KASAN's ability to detect
        out-of-bounds bugs in stack variables.

What is this doing here?
Huh, that is wrong. I needed that for build testing, but it shouldn't
have been added to the patch. I'm dropping that for the final
submission.

Thanks for spotting.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help