Thread (7 messages) 7 messages, 4 authors, 2022-06-28

Re: [PATCH v1 2/2] serial: Set probe_no_timeout for all DT based drivers

From: Saravana Kannan <hidden>
Date: 2022-06-28 16:25:33
Also in: linux-amlogic, linux-arm-msm, linux-aspeed, linux-gpio, linux-iommu, linux-mediatek, linux-mips, linux-pm, linux-riscv, linux-samsung-soc, linux-serial, linux-tegra, linuxppc-dev, lkml, sparclinux

On Tue, Jun 28, 2022 at 7:00 AM Tobias Klauser [off-list ref] wrote:
On 2022-06-28 at 04:01:03 +0200, Saravana Kannan [off-list ref] wrote:
quoted
diff --git a/drivers/tty/serial/8250/8250_acorn.c b/drivers/tty/serial/8250/8250_acorn.c
index 758c4aa203ab..5a6f2f67de4f 100644
--- a/drivers/tty/serial/8250/8250_acorn.c
+++ b/drivers/tty/serial/8250/8250_acorn.c
@@ -114,7 +114,6 @@ static const struct ecard_id serial_cids[] = {
 static struct ecard_driver serial_card_driver = {
      .probe          = serial_card_probe,
      .remove         = serial_card_remove,
-     .id_table       = serial_cids,
Is this change intentional? All other drivers are only changed to set
.probe_no_time and I don't see anything mentioned in the commit message
re. this driver's change.
No, that's a mistake. Thanks for catching it! I'll check this patch again.

-Saravana
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help