Thread (46 messages) 46 messages, 5 authors, 2022-07-07

Re: [PATCH bpf-next v2 3/8] bpf, iter: Fix the condition on p when calling stop.

From: Yonghong Song <hidden>
Date: 2022-06-20 18:48:39
Also in: bpf, cgroups, lkml


On 6/10/22 12:44 PM, Yosry Ahmed wrote:
From: Hao Luo <redacted>

In bpf_seq_read, seq->op->next() could return an ERR and jump to
the label stop. However, the existing code in stop does not handle
the case when p (returned from next()) is an ERR. Adds the handling
of ERR of p by converting p into an error and jumping to done.

Because all the current implementations do not have a case that
returns ERR from next(), so this patch doesn't have behavior changes
right now.

Signed-off-by: Hao Luo <redacted>
Signed-off-by: Yosry Ahmed <redacted>
Acked-by: Yonghong Song <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help