Re: [PATCH 01/12] x86/mce: use correct format characters
From: Randy Dunlap <hidden>
Date: 2022-06-09 23:16:20
Also in:
alsa-devel, linux-acpi, linux-edac, linux-mm, lkml, llvm, netfilter-devel
On 6/9/22 15:16, Bill Wendling wrote:
From: Bill Wendling <redacted>
When compiling with -Wformat, clang emits the following warnings:
arch/x86/kernel/cpu/mce/core.c:295:9: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
panic(msg);
^~~
Use a string literal for the format string.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Bill Wendling <redacted>
---
arch/x86/kernel/cpu/mce/core.c | 2 +-
scripts/Makefile.extrawarn | 4 ++--Where is the scripts/ change?
quoted hunk ↗ jump to hunk
2 files changed, 3 insertions(+), 3 deletions(-)diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index 2c8ec5c71712..3d411b7c85ad 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c@@ -292,7 +292,7 @@ static noinstr void mce_panic(const char *msg, struct mce *final, char *exp) if (!fake_panic) { if (panic_timeout == 0) panic_timeout = mca_cfg.panic_timeout; - panic(msg); + panic("%s", msg); } else pr_emerg(HW_ERR "Fake kernel panic: %s\n", msg);
-- ~Randy