Re: [PATCH net-next 5/5] net: dsa: realtek: rtl8365mb: handle PHY interface modes correctly
flat view
From: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Date: 2022-06-07 14:39:27
Also in:
lkml
quoted
That's a nice patch. But while dealing with ext interfaces, wouldn't it be nice to also add a mask for user ports? We could easily validate if a declared dsa port really exists.At best this will be useful to emit a warning for the device tree author. Can you see any other benefit?
No, that's it. It might avoid some headaches when someone simply assumes that ports are sequential. All models have holes in port sequences but it will get worse once we support a variant like RTL8363SC that port_id starts at 2. Regards, Luiz