On Thu, 16 Jun 2022 at 07:33, Jakub Kicinski [off-list ref] wrote:

On Wed, 15 Jun 2022 18:39:53 +0300 Nikolay Aleksandrov wrote:

quoted

quoted

quoted

Do we need the proc entry to be in jiffies when the netlink option is in ms?
Why not make it directly in ms (with _ms similar to other neigh _ms time options) ?

IMO, it would be better to be consistent with the netlink option which sets it in ms.

It seems the _ms options were added later and usually people want a more understandable
value, I haven't seen anyone wanting a jiffies version of a ms interval variable. :)

It was in jiffies because this entry was separated from `DELAY_PROBE_TIME`,
it keeps nearly all the things the same as `DELAY_PROBE_TIME`,
they are both configured by seconds and read to jiffies, was `ms` in
netlink attribute,
I think it's ok to keep this consistency, and is there a demand
required to configure it by ms?
If there is that demand, we can make it configured as ms.

no, no demand, just out of user-friendliness :) but
I get it keeping it as jiffies is also fine

+1 to using ms

If no one is against this, we can make configured as ms?

so, there will be updates as follow in the next version patch:
- make this option configured as ms, and rename it to `interval_probe_time`
- add documentation to Documentation/networking/ip-sysctl
- fix damaged whitespace
- fix missing `proc_*_jiffies_minmax` on `CONFIG_PROC_SYSCTL` is not defined