On Mon, Jun 6, 2022 at 4:22 PM Zhu, Lingshan [off-list ref] wrote:

On 6/2/2022 3:40 PM, Jason Wang wrote:

quoted

On Thu, Jun 2, 2022 at 10:48 AM Zhu Lingshan [off-list ref] wrote:

quoted

This commit fixes spars warnings: cast to restricted __le16
in function vdpa_dev_net_config_fill()

Signed-off-by: Zhu Lingshan <redacted>
---
  drivers/vdpa/vdpa.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
index 50a11ece603e..2719ce9962fc 100644
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c

@@ -837,11 +837,11 @@ static int vdpa_dev_net_config_fill(struct vdpa_device *vdev, struct sk_buff *ms
                     config.mac))
                 return -EMSGSIZE;

-       val_u16 = le16_to_cpu(config.status);
+       val_u16 = le16_to_cpu((__force __le16)config.status);

Can we use virtio accessors like virtio16_to_cpu()?

I will work out a vdpa16_to_cpu()

I meant __virtio16_to_cpu(true, xxx) actually here.

Thanks

Thanks,
Zhu Lingshan

quoted

Thanks

quoted

         if (nla_put_u16(msg, VDPA_ATTR_DEV_NET_STATUS, val_u16))
                 return -EMSGSIZE;

-       val_u16 = le16_to_cpu(config.mtu);
+       val_u16 = le16_to_cpu((__force __le16)config.mtu);
         if (nla_put_u16(msg, VDPA_ATTR_DEV_NET_CFG_MTU, val_u16))
                 return -EMSGSIZE;

--
2.31.1