Thread (8 messages) 8 messages, 6 authors, 2022-05-27

Re: [PATCH net-next] eth: de4x5: remove support for Generic DECchip & DIGITAL EtherWORKS PCI/EISA

From: Arnd Bergmann <arnd@arndb.de>
Date: 2022-05-20 12:31:19
Also in: linux-doc, linux-mips, linuxppc-dev

On Thu, May 19, 2022 at 4:13 AM Jakub Kicinski [off-list ref] wrote:
Looks like almost all changes to this driver had been tree-wide
refactoring since git era begun. There is one commit from Al
15 years ago which could potentially be fixing a real bug.

The driver is using virt_to_bus() and is a real magnet for pointless
cleanups. It seems unlikely to have real users. Let's try to shed
this maintenance burden.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: corbet@lwn.net
CC: tsbogend@alpha.franken.de
CC: mpe@ellerman.id.au
CC: benh@kernel.crashing.org
CC: paulus@samba.org
CC: sburla@marvell.com
CC: vburru@marvell.com
CC: aayarekar@marvell.com
CC: arnd@arndb.de
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
 .../device_drivers/ethernet/dec/de4x5.rst     |  189 -
 .../device_drivers/ethernet/index.rst         |    1 -
 arch/mips/configs/mtx1_defconfig              |    1 -
 arch/powerpc/configs/chrp32_defconfig         |    1 -
 arch/powerpc/configs/ppc6xx_defconfig         |    1 -
 drivers/net/ethernet/dec/tulip/Kconfig        |   15 -
 drivers/net/ethernet/dec/tulip/Makefile       |    1 -
 drivers/net/ethernet/dec/tulip/de4x5.c        | 5591 -----------------
 drivers/net/ethernet/dec/tulip/de4x5.h        | 1017 ---

I checked the defconfig files to make sure we are not removing the
last ethernet driver from
one of them. mtx1 has built-in networking and no PCI slot, so this is
definitely fine.
the ppc32 configs are for machines with PCI slots and also enable
multiple drivers but I saw
nothing specifically needing this card.

       Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help