Re: [RFC v8 net-next 05/16] pinctrl: ocelot: add ability to be used in a non-mmio configuration

On Sun, May 8, 2022 at 8:53 PM Colin Foster
[off-list ref] wrote:

There are a few Ocelot chips that contain pinctrl logic, but can be
controlled externally. Specifically the VSC7511, 7512, 7513 and 7514. In
the externally controlled configurations these registers are not
memory-mapped.

Add support for these non-memory-mapped configurations.

...

+#if defined(REG)

Redundant.

+#undef REG
+#endif

...

+               res = platform_get_resource(pdev, IORESOURCE_REG, 0);
+               if (!res) {
+                       dev_err(dev, "Failed to get resource\n");
+                       return -ENODEV;

return dev_err_probe(...); ?

+               }

...

        if (IS_ERR(info->map)) {
                dev_err(dev, "Failed to create regmap\n");
                return PTR_ERR(info->map);

Ditto.

-- 
With Best Regards,
Andy Shevchenko