Thread (8 messages) 8 messages, 2 authors, 2022-05-03

Re: [PATCH bpf-next v8 4/5] bpf: Add selftests for raw syncookie helpers

From: Maxim Mikityanskiy <hidden>
Date: 2022-05-03 17:14:27
Also in: bpf, linux-kselftest

On 2022-04-29 19:41, Alexei Starovoitov wrote:
On Fri, Apr 29, 2022 at 4:16 AM Maxim Mikityanskiy [off-list ref] wrote:
quoted
+       SYS("iptables -t raw -I PREROUTING \
+           -i tmp1 -p tcp -m tcp --syn --dport 8080 -j CT --notrack");
+       SYS("iptables -t filter -A INPUT \
+           -i tmp1 -p tcp -m tcp --dport 8080 -m state --state INVALID,UNTRACKED \
+           -j SYNPROXY --sack-perm --timestamp --wscale 7 --mss 1460");
+       SYS("iptables -t filter -A INPUT \
+           -i tmp1 -m state --state INVALID -j DROP");
+
+       ctrl_file = SYS_OUT("./xdp_synproxy --iface tmp1 --ports 8080 --single \
+                           --mss4 1460 --mss6 1440 --wscale 7 --ttl 64");
That doesn't work for test_progs-no_alu32.
sh: line 1: ./xdp_synproxy: No such file or directory
https://github.com/kernel-patches/bpf/runs/6227226675?check_suite_focus=true#step:6:7380

and going to be fragile in general.
Could you launch it as a kthread or fork it
like other tests are doing ?
A similar thing is done for the urandom_read binary used in another 
test. What I missed is adding my binary to the Makefile the same way. 
After adding it, both test_progs and test_progs-no_alu32 pass. 
Respinning with the fix.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help