Thread (61 messages) 61 messages, 11 authors, 2022-05-13

Re: [PATCH 28/32] selinux: Use mem_to_flex_dup() with xfrm and sidtab

From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Date: 2022-05-05 00:01:12
Also in: keyrings, linux-arm-msm, linux-bluetooth, linux-devicetree, linux-hardening, linux-hyperv, linux-integrity, linux-rdma, linux-scsi, linux-security-module, linux-usb, linux-wireless, llvm, selinux, xen-devel

Hi Paul,

On Wed, May 04, 2022 at 06:57:28PM -0400, Paul Moore wrote:
On Tue, May 3, 2022 at 9:57 PM Kees Cook [off-list ref] wrote:
[..]
quoted
+++ b/include/uapi/linux/xfrm.h
@@ -31,9 +31,9 @@ struct xfrm_id {
 struct xfrm_sec_ctx {
        __u8    ctx_doi;
        __u8    ctx_alg;
-       __u16   ctx_len;
+       __DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(__u16, ctx_len);
        __u32   ctx_sid;
-       char    ctx_str[0];
+       __DECLARE_FLEX_ARRAY_ELEMENTS(char, ctx_str);
 };
While I like the idea of this in principle, I'd like to hear about the
testing you've done on these patches.  A previous flex array
conversion in the audit uapi headers ended up causing a problem with
I'm curious about which commit caused those problems...?

Thanks
--
Gustavo
GCC12 and SWIG; while it was a SWIG problem and not a kernel header
problem that was thin consolation for those with broken builds.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help