Re: [PATCH] Bluetooth: Collect kcov coverage from hci_rx_work
From: Tamás Koczka <hidden>
Date: 2022-05-31 09:08:09
Also in:
linux-bluetooth, lkml
Hello Everyone, Thank you for reviewing the patch - I hope everything is going well. Please feel free to ask me if you need any more information regarding it! Thank you, Tamas On Tue, May 17, 2022 at 11:45 AM Tamas Koczka [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Annotate hci_rx_work() with kcov_remote_start() and kcov_remote_stop() calls, so remote KCOV coverage is collected while processing the rx_q queue which is the main incoming Bluetooth packet queue. Coverage is associated with the thread which created the packet skb. Signed-off-by: Tamas Koczka <redacted> --- net/bluetooth/hci_core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c index 45c2dd2e1590..703722031b8d 100644 --- a/net/bluetooth/hci_core.c +++ b/net/bluetooth/hci_core.c@@ -29,6 +29,7 @@ #include <linux/rfkill.h> #include <linux/debugfs.h> #include <linux/crypto.h> +#include <linux/kcov.h> #include <linux/property.h> #include <linux/suspend.h> #include <linux/wait.h>@@ -3780,7 +3781,9 @@ static void hci_rx_work(struct work_struct *work) BT_DBG("%s", hdev->name); - while ((skb = skb_dequeue(&hdev->rx_q))) { + for (; (skb = skb_dequeue(&hdev->rx_q)); kcov_remote_stop()) { + kcov_remote_start_common(skb_get_kcov_handle(skb)); + /* Send copy to monitor */ hci_send_to_monitor(hdev, skb); --2.36.0.550.gb090851708-goog