Re: [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators
From: Krzysztof Kozlowski <hidden>
Date: 2022-05-19 09:55:38
Also in:
linux-arm-kernel, linux-devicetree, linux-sunxi, lkml
On 18/05/2022 22:09, Corentin Labbe wrote:
Add entries for the new optional regulators.
Please explain why do you need it.
quoted hunk ↗ jump to hunk
Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- Documentation/devicetree/bindings/net/ethernet-phy.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml index ed1415a4381f..bd59e5cc0a55 100644 --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml@@ -153,6 +153,15 @@ properties: used. The absence of this property indicates the muxers should be configured so that the external PHY is used. + regulators: + description: + List of phandle to regulators needed for the PHY
I don't understand that... is your PHY defining the regulators or using supplies? If it needs a regulator (as a supply), you need to document supplies, using existing bindings.
+
+ regulator-names:
+ description:
+ List of regulator name strings sorted in the same order as the
+ regulators property.
+
resets:
maxItems: 1
Best regards, Krzysztof