Re: [PATCH v2 4/4] powerpc/52xx: Convert to use fwnode API

From
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date
2022-05-16 14:05:40
Also in
linux-can, linux-i2c, linux-ide, linux-serial, linux-spi, linuxppc-dev, lkml
Reply to
Michael Ellerman, 2022-05-16
On Mon, May 16, 2022 at 11:48:05PM +1000, Michael Ellerman wrote:
Andy Shevchenko [off-list ref] writes:
quoted
We may convert the GPT driver to use fwnode API for the sake
of consistency of the used APIs inside the driver.
I'm not sure about this one.

It's more consistent to use fwnode in this driver, but it's very
inconsistent with the rest of the powerpc code. We have basically no
uses of the fwnode APIs at the moment.
Fair point!
It seems like a pretty straight-forward conversion, but there could
easily be a bug in there, I don't have any way to test it. Do you?
Nope, only compile testing. The important part of this series is to
clean up of_node from GPIO library, so since here it's a user of
it I want to do that. This patch is just ad-hoc conversion that I
noticed is possible. But there is no any requirement to do so.

Lemme drop this from v3.


-- 
With Best Regards,
Andy Shevchenko

Thread (10 messages) 10 messages, 3 authors, last reply 2022-06-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help