Re: [PATCH 1/2] kallsyms: add kallsyms_show_value definition in all cases

On Thu, May 12, 2022 at 09:16:50AM +0530, Maninder Singh wrote:

quoted

On Wed, May 11, 2022 at 01:36:56PM +0530, Maninder Singh wrote:

...

quoted

This is printing raw kernel addresses with no hashing, as far as I can
tell. That's not okay at all.

yes same was suggested by Petr also, because earlier we were printing base address also as raw address.

https://lkml.org/lkml/2022/2/28/847

but then modified approach to print base address as hash when we are going to show offset of module address,
but when we print complete address then we thought of keeping it same as it was:

original:
 [12.487424] ps 0xffff800000eb008c
with patch:
 [9.624152] ps 0xffff800001bd008c [crash]

But if its has to be hashed, will fix that also.

In such case it should be a separate change since it will be the one that
changes behaviour.

-- 
With Best Regards,
Andy Shevchenko