Re: [PATCH v3] ath10k: improve BDF search fallback strategy

Kalle Valo [off-list ref] writes:

quoted

 static int ath10k_core_fetch_board_data_api_n(struct ath10k *ar,
 					      const char *boardname,
-					      const char *fallback_boardname1,
-					      const char *fallback_boardname2,
 					      const char *filename)
 {
-	size_t len, magic_len;
+	size_t len, magic_len, board_len;
 	const u8 *data;
 	int ret;
+	char temp_boardname[100];
+
+	board_len = 100 * sizeof(temp_boardname[0]);

Why not:

board_len = sizeof(temp_board-name);

That way number 100 is used only once.

BTW I'm not sure if it makes sense to CC David, Eric, Jakub and Paolo.
I'm sure they get a lot of email already. And I would also drop netdev.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches