Re: [PATCH] net: phy: micrel: Fix incorret variable type in micrel

Hi, Andrew

On 2022/5/9 21:53, Andrew Lunn wrote:

On Mon, May 09, 2022 at 09:49:51PM +0800, Wan Jiabing wrote:

quoted

In lanphy_read_page_reg, calling __phy_read() might return a negative
error code. Use 'int' to check the negative error code.

Hi Wan

As far as the code goes, this looks good.

Please could you add a Fixes: tag, to indicate where the problem was
introduced. Please also read the netdev FAQ, so you can correctly set
the patch subject. This should be against the net tree, since it is a
fix.

Thanks
	Andrew

OK, I'll fix it in v2.

Thanks,
Wan Jiabing