Re: [PATCH net-next v2] net: ifdefy the wireless pointers in struct net_device

From
Johannes Berg <johannes@sipsolutions.net>
Date
2022-05-18 18:59:45
Also in
linux-wireless
Reply to
Jakub Kicinski, 2022-05-18
On Wed, 2022-05-18 at 11:18 -0700, Jakub Kicinski wrote:
Most protocol-specific pointers in struct net_device are under
a respective ifdef. Wireless is the notable exception. Since
there's a sizable number of custom-built kernels for datacenter
workloads which don't build wireless it seems reasonable to
ifdefy those pointers as well.

While at it move IPv4 and IPv6 pointers up, those are special
for obvious reasons.
Not sure if the "ifdefy" in the subject is intentional, reads a bit odd
to me :) but anyway looks good

Acked-by: Johannes Berg <johannes@sipsolutions.net>


Do you want me to follow up with trying to union the pointer into
ml_priv?

I prefer to union it rather than use ml_priv because we'll not want to
use the getter everywhere when we already know, only on the boundaries.

johannes
Thread (5 messages) 5 messages, 4 authors, last reply 2022-05-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help