Re: [PATCH net-next 3/6] eth: switch to netif_napi_add_weight()
From: Edward Cree <ecree.xilinx@gmail.com>
Date: 2022-05-11 17:58:01
On 06/05/2022 18:07, Jakub Kicinski wrote:
quoted hunk ↗ jump to hunk
Switch all Ethernet drivers which use custom napi weights to the new API. Signed-off-by: Jakub Kicinski <kuba@kernel.org> ---diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c index eec80b024195..3f28f9861dfa 100644 --- a/drivers/net/ethernet/sfc/efx_channels.c +++ b/drivers/net/ethernet/sfc/efx_channels.c@@ -1316,8 +1316,8 @@ void efx_init_napi_channel(struct efx_channel *channel) struct efx_nic *efx = channel->efx; channel->napi_dev = efx->net_dev; - netif_napi_add(channel->napi_dev, &channel->napi_str, - efx_poll, napi_weight); + netif_napi_add_weight(channel->napi_dev, &channel->napi_str, efx_poll, + napi_weight); }
This isn't really a custom weight; napi_weight is initialised to 64 and never changed, so probably we ought to be just using NAPI_POLL_WEIGHT here and end up on the non-_weight API. Same goes for Falcon. -ed