Re: [PATCH net-next v3 4/6] ptp: Support late timestamp determination
From: Richard Cochran <richardcochran@gmail.com>
Date: 2022-05-05 14:02:19
On Sun, May 01, 2022 at 01:18:34PM +0200, Gerhard Engleder wrote:
quoted hunk ↗ jump to hunk
@@ -620,6 +625,11 @@ enum { */ SKBTX_HW_TSTAMP_USE_CYCLES = 1 << 3, + /* determine hardware time stamp based on time or cycles, flag is used + * only for RX path + */ + SKBTX_HW_TSTAMP_NETDEV = 1 << 3,
Rather than re-using bit 3, why not just use bit 5? Then you can: - remove the magic clearing in patch #2 - protect against future changes that would skip the magic clearing
/* generate wifi status information (where possible) */ SKBTX_WIFI_STATUS = 1 << 4,
Thanks, Richard