Re: [PATCH net-next v3 2/8] dt-bindings: phy: add the "fsl,lynx-28g" compatible
From: Krzysztof Kozlowski <hidden>
Date: 2022-03-10 16:47:40
Also in:
linux-devicetree, linux-phy
On 10/03/2022 15:51, Ioana Ciornei wrote:
Describe the "fsl,lynx-28g" compatible used by the Lynx 28G SerDes PHY driver on Layerscape based SoCs.
The message is a bit misleading, because it suggests you add only compatible to existing bindings. Instead please look at the git log how people usually describe it in subject and message.
quoted hunk ↗ jump to hunk
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> --- Changes in v2: - none Changes in v3: - 2/8: fix 'make dt_binding_check' errors .../devicetree/bindings/phy/fsl,lynx-28g.yaml | 98 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 99 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/fsl,lynx-28g.yamldiff --git a/Documentation/devicetree/bindings/phy/fsl,lynx-28g.yaml b/Documentation/devicetree/bindings/phy/fsl,lynx-28g.yaml new file mode 100644 index 000000000000..e98339ec83a7 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/fsl,lynx-28g.yaml@@ -0,0 +1,98 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/fsl,lynx-28g.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale Lynx 28G SerDes PHY binding + +maintainers: + - Ioana Ciornei <ioana.ciornei@nxp.com> + +properties: + compatible: + enum: + - fsl,lynx-28g + + reg: + maxItems: 1 + + "#phy-cells": + const: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +required: + - compatible + - reg + - "#phy-cells" + - "#address-cells" + - "#size-cells" + +patternProperties: + '^phy@[0-9a-f]$': + type: object + properties: + reg: + description: + Number of the SerDes lane. + minimum: 0 + maximum: 7 + + "#phy-cells": + const: 0
Why do you need all these children? You just enumerated them, without statuses, resources or any properties. This should be rather just index of lynx-28g phy.
+
+ additionalProperties: false
+
+additionalProperties: false
+
+examples:
+ - |
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ serdes_1: serdes_phy@1ea0000 {node name just "phy"
+ compatible = "fsl,lynx-28g";
+ reg = <0x0 0x1ea0000 0x0 0x1e30>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ #phy-cells = <1>;
+
+ serdes1_lane_a: phy@0 {
+ reg = <0>;
+ #phy-cells = <0>;
+ };Best regards, Krzysztof